Add command-line options #90
Conversation
|
hey, what's the status on this? This looks good to me |
|
@lionkor As far as I know it is done. I made it a draft since I don't know the codebase too well, and didn't know if I implemented the feature in all relevant places. If you think it looks good, then it should be ready to merge. |
these will be replaced by #90 eventually
|
Could we please also add a |
these will be replaced by #90 eventually
these will be replaced by #90 eventually
WiserTixx
force-pushed
the
cli-arguments
branch
from
2fb5e53 to
5f84a55
Compare
WiserTixx
force-pushed
the
cli-arguments
branch
from
5f84a55 to
1a01096
Compare
WiserTixx
force-pushed
the
cli-arguments
branch
from
a9b8e7e to
c744c6e
Compare
|
@WiserTixx let's remove the skip ssl verify again since we don't have it/dont need it in the curl branch, which is merged |
src/Startup.cpp
Outdated
| std::string Arg; | ||
| for (int c = 2; c <= argc; c++) { | ||
| for (int c = 0; c <= options.game_arguments_length; c++) { |
There was a problem hiding this comment.
Is this correct? Shouldn't this pass the entire argc/argv, since we're relaunching the launcher, not the game, here? Same for the other Relaunch/URelaunch ones
| @@ -183,26 +183,13 @@ void CheckForUpdates(int argc, char* args[], const std::string& CV) { | |||
| "&pk=" | |||
| + PublicKey + "&branch=" + Branch, | |||
| EP); | |||
| URelaunch(argc, args); | |||
| URelaunch(); | |||
| #endif | |||
| } else | |||
There was a problem hiding this comment.
Let's please add a print when the no_update parameter is set, so that people know that their launcher is outdated but that the update was not applied
| void CustomPort(int argc, char* argv[]) { | ||
| if (argc > 1) { | ||
| std::string Port = argv[1]; | ||
| if (Port.find_first_not_of("0123456789") == std::string::npos) { | ||
| if (std::stoi(Port) > 1000) { | ||
| DEFAULT_PORT = std::stoi(Port); | ||
| warn("Running on custom port : " + std::to_string(DEFAULT_PORT)); | ||
| } | ||
| } | ||
| if (argc > 2) | ||
| Dev = true; | ||
| } | ||
| } |
WiserTixx
force-pushed
the
cli-arguments
branch
from
bb8a06e to
a73f6d5
Compare
WiserTixx
force-pushed
the
cli-arguments
branch
from
a73f6d5 to
c99fecf
Compare
|
@lionkor I've fixed relauching and removed ssl verify. It's now also using the game_arguments when launching the game on windows. I have not implemented that for linux yet because I can't test it. |
|
It's the same for linux I would assume, please implement it, i'll test it |
WiserTixx
force-pushed
the
cli-arguments
branch
from
b91f1cd to
afac729
Compare
This PR adds command-line options as outlined in #74
Closes #74